Skip to content

Conversation

CarnaViire
Copy link
Member

Port docs added in dotnet/runtime#57719

Contributes to dotnet/runtime#43916

@CarnaViire CarnaViire requested a review from a team as a code owner September 3, 2021 13:54
@ghost
Copy link

ghost commented Sep 3, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Sep 3, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Port docs added in dotnet/runtime#57719

Contributes to dotnet/runtime#43916

Author: CarnaViire
Assignees: -
Labels:

area-Extensions-HttpClientFactory

Milestone: -

@gewarren
Copy link
Contributor

gewarren commented Sep 3, 2021

Docs Build status updates of commit bc8109c:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Http.Logging/LoggingHttpMessageHandler.xml ✅Succeeded View
xml/Microsoft.Extensions.Http.Logging/LoggingScopeHttpMessageHandler.xml ✅Succeeded View
xml/Microsoft.Extensions.Http/HttpMessageHandlerBuilder.xml ✅Succeeded View
xml/Microsoft.Extensions.Http/IHttpMessageHandlerBuilderFilter.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions.

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren
Copy link
Contributor

gewarren commented Sep 6, 2021

Docs Build status updates of commit 8b0110f:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Http.Logging/LoggingHttpMessageHandler.xml ✅Succeeded View
xml/Microsoft.Extensions.Http.Logging/LoggingScopeHttpMessageHandler.xml ✅Succeeded View
xml/Microsoft.Extensions.Http/HttpMessageHandlerBuilder.xml ✅Succeeded View
xml/Microsoft.Extensions.Http/IHttpMessageHandlerBuilderFilter.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked that inheritdoc is working for SendAsync.

@CarnaViire CarnaViire merged commit edfb1ff into dotnet:net6-rc1 Sep 7, 2021
@CarnaViire CarnaViire deleted the thhpclientfactory-docs-port branch September 7, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants